Home → Problems →

Continued Injection warnings with SignalCommandMap

• Edit

bill

20 Oct, 2011 06:39 PM

Hey guys,

I continue to have issues with injection warnings when using SignalCommandMap. It seems to have to do with the frequency of signal usage, using like value classes in more than one signal class, and injecting signals inside commands. Most of the time, it doesn't interfere with app performance, but makes me nervous just the same. I've seen a number of work-arounds and have decided (for now) to abandon the SignalCommandMap in favor of Eidiot's SignalExecutorMap (http://eidiot.net/en/2010/03/24/signalexecutormap-another-way-to-ma...). Anybody else having these issues.

1. 1 Posted by Stray on 20 Oct, 2011 08:09 PM

   

   Hi Bill - which version of SCM are you using? The latest one should be cleaning up its own injections - this warning was seen in a prior version but shouldn't be present in the latest.

   They actually showed up a hole in the SCM but we did fix it several months ago. (Mappings were being accidentally left lying around)

   So - I'm thinking you're using a very old version? If not then let me know because it means the git commits have somehow got scrambled and the patch has been lost.

   I wouldn't go with an old one - the interfaces for Signals have been in flux and you'll run into compatibility issues.

   Stray

   • Edit

2. 2 Posted by bill on 20 Oct, 2011 08:30 PM

   

   Grrrr.

   I just made a separate clone of https://github.com/joelhooks/signals-extensions-CommandSignal.git and found differences despite doing a git pull on the original. I will try again. The SignalExecutorMap works, but has potential issues with interfaces and garbage collection. It would help if Joel would put a version readme in the repo.

   • Edit

3. 3 Posted by bill on 20 Oct, 2011 09:04 PM

   

   Yep, that did it. No more injection errors.

   Thx Stray.

   • Edit

4. bill closed this discussion on 20 Oct, 2011 09:04 PM.