Home → Problems →

Parameter definitionName must be non-null.

• Edit

Chris

10 Oct, 2012 06:12 AM

I'm trying to inject a Date when I get this error. My context class has:-

injector.mapSingleton(Date);

and my mediator has:-

[Inject]
public var calendarCurrentDate:Date

What am I missing here?

I am using RLv1.5.2 with Signals and the trace stack is:-

TypeError: Error #2007: Parameter definitionName must be non-null.
    at flash.system::ApplicationDomain/getDefinition()
    at org.swiftsuspenders.injectionpoints::MethodInjectionPoint/gatherParameterValues()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/injectionpoints/MethodInjectionPoint.as:98]
    at org.swiftsuspenders.injectionpoints::ConstructorInjectionPoint/applyInjection()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/injectionpoints/ConstructorInjectionPoint.as:37]
    at org.swiftsuspenders::Injector/instantiate()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/Injector.as:138]
    at org.swiftsuspenders.injectionresults::InjectSingletonResult/createResponse()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/injectionresults/InjectSingletonResult.as:40]
    at org.swiftsuspenders.injectionresults::InjectSingletonResult/getResponse()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/injectionresults/InjectSingletonResult.as:31]
    at org.swiftsuspenders::InjectionConfig/getResponse()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/InjectionConfig.as:43]
    at org.swiftsuspenders::InjectionConfig/getResponse()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/InjectionConfig.as:49]
    at org.swiftsuspenders.injectionpoints::PropertyInjectionPoint/applyInjection()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/injectionpoints/PropertyInjectionPoint.as:36]
    at org.swiftsuspenders::Injector/injectInto()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/Injector.as:125]
    at org.swiftsuspenders::Injector/instantiate()[/Development/Projects/SwiftSuspenders/src/org/swiftsuspenders/Injector.as:139]
    at org.robotlegs.base::MediatorMap/createMediatorUsing()[/Development/Projects/Robotlegs/robotlegs-framework/src/org/robotlegs/base/MediatorMap.as:297]
    at org.robotlegs.base::MediatorMap/onViewAdded()[/Development/Projects/Robotlegs/robotlegs-framework/src/org/robotlegs/base/MediatorMap.as:278]
    at flash.display::DisplayObjectContainer/addChildAt()
...

1. Support Staff 1 Posted by Till Schneidere... on 10 Oct, 2012 08:11 AM

   

   Looks like something's going wrong with the Date object's creation.
   Date is a pretty, well, "special" class, and it doesn't surprise me
   too much that Swiftsuspenders doesn't handle its creation too well.

   If your use-case allows that, try changing the mapping to
   `injector.mapValue(new Date());

   that should do the trick.

   cheers,
   till

   • Edit

2. Support Staff 2 Posted by Ondina D.F. on 10 Oct, 2012 09:37 AM

   

   Hey Till and Chris,

   I was curious why the Date Class behaves like this.

   Could it be that the (dummy) constructor of the Date Class is the cause of the issue? The parameters have no type declaration.

   http://hg.mozilla.org/tamarin-redux/file/f5191c18b0e4/core/Date.as

   // Dummy constructor function - This is neccessary so the compiler can do arg # checking for the ctor in strict mode

   // The code for the actual ctor is in DateClass::construct in the avmplus

   public function Date(year = void 0, month = void 0, date = void 0, hours = void 0, minutes = void 0, seconds = void 0, ms = void 0)
           {}
   

   I’ve created a custom class with a constructor like the one of the Date Class, and I got the same error (Parameter definitionName must be non-null.), if the parameters have no type declaration.

   In SwifSuspenders, MethodInjectionPoint.gatherParameterValues. parameterConfig.typeName is null, therefore getDefinition() throws a reference error.

   Of course that’s not a solution, but I just tried it out to see how it works, and it works:

   if(!parameterConfig.typeName)
       parameterConfig.typeName="Object";
   
   var config : InjectionConfig = injector.getMapping(Class(
   injector.getApplicationDomain().getDefinition(parameterConfig.typeName)),
   parameterConfig.injectionName);
   

   Ondina

   • Edit

3. Support Staff 3 Posted by Till Schneidere... on 10 Oct, 2012 09:43 AM

   

   Hey Ondina,

   thanks for investigating! Looks like you're right: the missing types
   are the problem. Without looking at the code, I don't really
   understand (or remember) why Swiftsuspenders trips over that, as it
   should theoretically just find out about the missing types and ignore
   the arguments, creating a date without a parameter-less ctor. Maybe I
   never actually tested with arguments that don't have any type
   annotations, but only with ones that have "*" annotations?

   This will certainly not be fixed in 1.5.x, but it's probably worth
   doing so for 2.0.

   • Edit

4. Support Staff 4 Posted by Ondina D.F. on 10 Oct, 2012 09:55 AM

   

   Thanks for the clarification, Till.

   This will certainly not be fixed in 1.5.x, but it's probably worth doing so for 2.0.

   Cool. Looking forward to it :)

   • Edit

5. Support Staff 5 Posted by Ondina D.F. on 10 Oct, 2012 12:02 PM

   

   @Chris & @all whom it may concern

   It seems that Date is not the only class having a dummy constructor with no type declaration for params. I don’t know how many such classes there are, but Number, Boolean, Float, RegExp, String are some of them.

   If you get an error like this:

   TypeError: Error # 2007: Parameter definitionName must be non-null.

   it probably means that the class you’re trying to map is one of the above mentioned or similar.

   So, until Till fixes the issue in 2.0, and for versions under 2.0 the solution is the one Till mentioned, without the typo:

   injector.mapValue(Date, new Date());

   or
   var myDate:Date=new Date();
   injector.mapValue(Date, myDate);

   The following mapping won’t work for the same reasons mentioned in the previous posts:

   var myDate:Date=injector.instantiate(Date);
   injector.mapValue(Date, myDate);

   • Edit

6. 6 Posted by Chris on 12 Oct, 2012 02:47 AM

   

   Using injector.mapValue s working for me.

   • Edit

7. Chris closed this discussion on 12 Oct, 2012 02:47 AM.